[waffle] [PATCH 0/4] Support XCode 3.1, which lacks TLS

Nigel Stewart nigels.com at gmail.com
Thu Jul 11 07:30:15 PDT 2013


Chad,

I did need to make one little fix to resolve a crash, attached.
Otherwise, working fine here, thanks!

Tested with XCode 3.1 gcc, XCode 4.6.2 clang.

- Nigel

On Thu, Jul 11, 2013 at 2:12 AM, Chad Versace
<chad.versace at linux.intel.com> wrote:
> This patch series lives on my branch testing/support-for-no-tls at
> git://people.freedesktop.org/~chadversary/waffle.git .
>
> It adds code paths in wcore_tinfo.c to support development environments that
> don't support thread-local storage. Clang < 3.2, for example, lacks TLS.
>
> Nigel or Jeff, could you please test these patches with XCode 3.1? I currently
> don't have a Mac system to test on (but that will soon be fixed).  I wouldn't
> be surprised if I used some pthread features unsupported on Mac OS.
>
> I tested the series on Linux with Clang 3.3 by running `make check-func`.
> I tested once with WAFFLE_HAS_TLS defined and again undefined, to simulate an
> environment without TLS. Both runs looked good.
>
> Chad Versace (4):
>   core: Refactor wcore_tinfo.c
>   core: Prevent leak at thread exit
>   core: Support systems without thread-local storage
>   Revert "cmake: Require that compiler support keyword '__thread'"
>
>  CMakeLists.txt                |  4 +-
>  src/waffle/core/wcore_tinfo.c | 98 +++++++++++++++++++++++++++++++++++--------
>  2 files changed, 83 insertions(+), 19 deletions(-)
>
> --
> 1.8.3.1
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-fix-For-non-WAFFLE_HAS_TLS-path-need-to-initialize-w.patch
Type: application/octet-stream
Size: 764 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/waffle/attachments/20130711/81598b85/attachment.obj>


More information about the waffle mailing list