[waffle] [PATCH 0/3] cgl: Handle requested context version more leniently

[Chad Versace]

On 07/19/2013 09:43 PM, Chad Versace wrote:
> This series tries to improve Waffle's Mac support by more intelligently
> processing the requested OpenGL context version. This series lives on my branch
> 'testing/cgl-context-flavors'.
>
> Nigel or Jeff, could you please review the sanity of this series and test it on
> a Mac with `make check-func`? That will run unit tests as well as functional
> tests.  If the testrun reports only passes and skips, no failures, then the
> testsuite results are good.
>
> I haven't tested the patches mysef because I currently don't have a Mac to test
> with.  (Next week I will have available a Mac with OS X Lion for testing, but
> I wanted to send out the patches for your review ASAP). For complete test
> coverage, this series should be tested on two Macs, one with OpenGL 3.2 support
> and one without. But any testing is better than no testing.
>
> The meat of the series is patch 2.
>
> Chad Versace (3):
>    cgl: Emit error on OS X pre-10.6 on attempt to create 3.2 context
>    cgl: Handle requested context version more leniently
>    tests/gl_basic/cgl: Test various GL context flavors
>
>   src/waffle/cgl/cgl_config.m      |  89 +++++++++++++---
>   tests/functional/gl_basic_test.c | 223 +++++++++++++++++++++++++++++++++++++++
>   2 files changed, 297 insertions(+), 15 deletions(-)
>


I'm not an Apple programmer, so I'm a bit confused. Are the compile-time
checks for OS version sufficient in this series? Or do we need to check
the OS version at runtime instead?