[waffle] [PATCH 0/6] wflinfo: Make wflinfo understand OpenGL 3.1 profiles

[Jordan Justen]

On Mon, Apr 28, 2014 at 8:43 PM, Chad Versace
<chad.versace at linux.intel.com> wrote:
> After this series, the following all do what the user wants them to do.
>     wflinfo --api=gl --version=3.1
>     wflinfo --api=gl --version=3.1 --profile=none
>     wflinfo --api=gl --version=3.1 --profile=core
>     wflinfo --api=gl --version=3.1 --profile=compat
>
> Likewise, if the user provided a profile but no version, like this...
>     wflinfo --api=gl --profile=core
>     wflinfo --api=gl --profile=compat
> then wflinfo will also try creating an OpenGL 3.1 context.
>
> DISCLAIMER: I've only tested these patches on Intel Ivybride, which exposes
> only core profile for OpenGL 3.1 and above. Someone really needs to test this
> on a system that exposes an OpenGL 3.1 compatibility context, but I don't have
> access to one. If no one steps up to test that, then we can commit now and
> fix bugs later.

Patches 1-4 Reviewed-by: Jordan Justen <jordan.l.justen at intel.com>

These results (on nvidia with GL 4.4) could be better:

$ bin/wflinfo -p glx -a gl -V 3.1 --profile=core
Waffle error: 0x0 WAFFLE_NO_ERROR

$ bin/wflinfo -p glx -a gl -V 3.1 --profile=compat
Waffle error: 0x0 WAFFLE_NO_ERROR

Removing -V works as expected though.

origin/master gives:

$ bin/wflinfo -p glx -a gl -V 3.1 --profile=core
Waffle error: 0x8 WAFFLE_ERROR_BAD_ATTRIBUTE: for OpenGL < 3.2,
WAFFLE_CONTEXT_PROFILE must be WAFFLE_NONE

$ bin/wflinfo -p glx -a gl -V 3.1 --profile=compat
Waffle error: 0x8 WAFFLE_ERROR_BAD_ATTRIBUTE: for OpenGL < 3.2,
WAFFLE_CONTEXT_PROFILE must be WAFFLE_NONE

-Jordan

> This series lives on my wflinfo-3.1-v04 branch at
> https://github.com/chadversary/waffle/tree/wflinfo-3.1-v04
>
> I believe this is final feature needed for waffle-1.4.
>
> So, after this series lands and the few remaining 1.4 blocker issues on
> https://github.com/waffle-gl/waffle/issues?milestone=1&state=open get resolved,
> I'll send out a wafle-1.4 release candidate announcement.
>
> Chad Versace (6):
>   wflinfo: Don't modify struct options after initialization
>   wflinfo: Cleanup signature of wflinfo_try_create_context()
>   wflinfo: Cleanup signature of wflinfo_create_context()
>   wflinfo: Replace s/-1/WAFFLE_DONT_CARE/ when relevant
>   wflinfo: Distinguish between cmdline options and func options
>   wflinfo: Make wflinfo understand OpenGL 3.1 profiles
>
>  src/utils/wflinfo.c | 355 +++++++++++++++++++++++++++++++++++++++++++++-------
>  1 file changed, 307 insertions(+), 48 deletions(-)
>
> --
> 1.9.0
>
> _______________________________________________
> waffle mailing list
> waffle at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/waffle