[waffle] [PATCH 14/18] cmake: set most compiler flags/defines in a single location
chad.versace at linux.intel.com
Mon Aug 4 00:23:21 PDT 2014
On 07/22/2014 08:31 PM, Emil Velikov wrote:
> Do not define the same thing (_XOPEN_SOURCE) three times and use
> compiler specific flags.
> - GCC: Move visibility=hidden to global scale.
> - WIN32: Don't do TLS.
> - Static link Windows builds
> - MINGW: link-in libgcc*.dll
> - MSVC: link-in msvcrt*.dll
> Signed-off-by: Emil Velikov <emil.l.velikov at gmail.com>
This patch is
Reviewed-by: Chad Versace <chad.versace at linux.intel.com>
though I don't really grok the Windows bits. It's reviewed
as in "it doesn't break Linux" ;)
More information about the waffle