[waffle] [PATCH 0/8] make check cleanup & windows support

Chad Versace chad.versace at linux.intel.com
Wed Aug 20 15:55:46 PDT 2014

On 08/20/2014 05:58 AM, Emil Velikov wrote:
> On 20/08/14 00:38, Chad Versace wrote:
>> On 08/04/2014 07:34 AM, Emil Velikov wrote:

> TEST_RUN2(gl_basic, glx_gl20, all_gl20); TEST_RUN2(gl_basic,
> glx_gl21, all_gl21);
> Note that this still gives us a ton of duplication, yet I feel that
> any further cleanups can be made at a later point :)
> I have pushed the TEST_RUN2 approach in branch 
> 'for-upstream-make-check-rework-1.3' and have tested it under Linux.
> Let me know if you like the approach and it I should recent the
> massive mechanical changes to the ML.

I like the TEST_RUN2 approach. It avoids some of the duplication in my proposed

I found one error in the series. Commit df9027a024d5bcdce1b27d608a2986ebf0e089e8,
which refactors the gles tests, has a copy-paste error. It assigns wayland names
to some x11_egl tests.

Also, the cmake commit 3d5c7fd2e2181c3ab88a30ec376a7fd6ff487eee has some garbled

+# Ensure that the executable is in the same folder as the library it's linke       
+# against. Otherwise Windows will fail to load the DLL, and the test will fa
                                                                            ^^^^ fail. 

With the copy-paste error and the typos fixed, the whole series is
Reviewed-by: Chad Versace <chad.versace at linux.intel.com>

More information about the waffle mailing list