[waffle] [PATCH 4/4] wgl: attempt to fix the final test
emil.l.velikov at gmail.com
Thu Aug 21 05:45:46 PDT 2014
On 21/08/14 00:11, Chad Versace wrote:
> On 08/19/2014 11:42 AM, Jose Fonseca wrote:
>> On 19/08/14 18:44, Emil Velikov wrote:
>>> On 19 August 2014 16:51, Jose Fonseca <jfonseca at vmware.com> wrote:
>>>> On 19/08/14 16:41, Jose Fonseca wrote:
>> I'm sure it overflows on Linux too. valgrind might complain.
>> But MSVC emits code to check for stack overflow -- some sort of canary. There is no "crash" per se -- but an error dialog.
> To catch bugs like this, maybe it's time that waffle gets a `make check-valgrind`.
> Or maybe build with -fstack-protector by default.
Hmm adding "make check-varglind" should be too hard - I will give it a bash.
> waffle mailing list
> waffle at lists.freedesktop.org
More information about the waffle