[waffle] [PATCH 1/3] cmake: drop the LINK_INTERFACE_LIBRARIES hack

Emil Velikov emil.l.velikov at gmail.com
Thu Aug 21 12:30:52 PDT 2014


It was added in order to silence Debian's packagin system which
detected that wflinfo has unused direct deps (is overlinked).
Properly annotate waffle's libdeps as PRIVATE this way they won't
get propagated to wflinfo and other objects that link against
libwaffle.

Signed-off-by: Emil Velikov <emil.l.velikov at gmail.com>
---
 src/waffle/CMakeLists.txt | 9 +--------
 1 file changed, 1 insertion(+), 8 deletions(-)

diff --git a/src/waffle/CMakeLists.txt b/src/waffle/CMakeLists.txt
index 954db78..0a84e60 100644
--- a/src/waffle/CMakeLists.txt
+++ b/src/waffle/CMakeLists.txt
@@ -191,7 +191,7 @@ include_directories(
     )
 
 add_library(${waffle_libname} SHARED ${waffle_sources})
-target_link_libraries(${waffle_libname} ${waffle_libdeps})
+target_link_libraries(${waffle_libname} PRIVATE ${waffle_libdeps})
 
 set_target_properties(${waffle_libname}
     PROPERTIES
@@ -208,13 +208,6 @@ if(waffle_on_windows)
     )
 endif()
 
-if(NOT waffle_on_mac)
-    set_target_properties(${waffle_libname}
-        PROPERTIES
-        LINK_INTERFACE_LIBRARIES ""
-        )
-endif()
-
 install(
     TARGETS ${waffle_libname}
     RUNTIME DESTINATION ${CMAKE_INSTALL_BINDIR}
-- 
2.0.2



More information about the waffle mailing list