[waffle] [PATCH] cmake: Find and set include path for wglext.h

Chad Versace chad.versace at linux.intel.com
Wed Dec 3 10:52:00 PST 2014


On 11/26/2014 04:01 AM, Jose Fonseca wrote:
> On 26/11/14 11:33, Emil Velikov wrote:
>> Thanks for the reminder Jose.
>>
>> The general consensus in #cmake (halfway though the GSoC) was that
>> find_package(OpenGL REQUIRED) for Windows development is (should) not be
>> needed, thus I've dropped it ages ago.
> 
> Actually I added that line by mistake.
> 
> You mean, basically OpenGL is guaranteed to be supported on Windows, as it's part of the Window SDKs (or MinGW headers).  Never thought of that, but yeah, makes sense.
> 
> This line is probably better left out then.


Jose, do you want me to remove the line
>>>> +    find_package(OpenGL REQUIRED)
before committing or leave it in?

>> Either way the commit looks good imho.
>> Reviewed-by: Emil Velikov <emil.l.velikov at gmail.com>



-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 884 bytes
Desc: OpenPGP digital signature
URL: <http://lists.freedesktop.org/archives/waffle/attachments/20141203/9f8d07fa/attachment.sig>


More information about the waffle mailing list