[waffle] [PATCH] revert commit 92116dae to make it build with cmake < 2.8.12

[Emil Velikov]

On 5 December 2014 at 07:20, Chad Versace <chad.versace at linux.intel.com> wrote:
> Jordan and Emil, does reverting 92116dae break anything for you? I don't
> have a Debian-based machine, (and this CMake hack was made specifically
> to silence Debian warnings), so I don't want to commit this without your ok.
>
Don't think anything was ever "broken" per say, just a bad practise
that the Debian build caught for us.

> If this revert causes Debian any problems, then I think the next best
> thing is to apply the original CMake hack if cmake<=2.8.11 and use
> PRIVATE and cmake>=2.8.12. In fact, that may be better than the revert.
> What do you think?
>
> if (CMAKE_MAJOR_VERSION EQUAL 2 AND
>     CMAKE_MINOR_VERSION EQUAL 8 AND
>     CMAKE_PATCH_VERSION LESS 12)
>   # Do old LINK_INTERFACE_LIBRARIES hack.
> else()
>   # Use PRIVATE keyword.
> endif()
>
> Matej, Chrome OS also still ships cmake-2.8.11 and is carrying a similar
> patch. So I agree with you in that this problem needs to get fixed upstream.
>
Considering that there are at least a couple of serious users "stuck"
with 2.8.11 I would of for your suggestions Chad.
It looks gets the best of both worlds, as they say.

Thus one day as distros move to 2.8.12 we can bump the requirement.
Alternatively we can do so earlier if there is some very compelling
reason.

Thanks
Emil