[waffle] [PATCH 2/2] waffle: initial empty implementation of nacl backend

[Tapani]

On 12/15/2014 11:04 PM, Emil Velikov wrote:
> Hi Tapani,
>
> On 15/12/14 12:59, Tapani Pälli wrote:
>> Patch adds nacl platform skeleton. Only thing is does is that
>> it creates a container that holds the 3D context object and is
>> responsible for any communication required with browser.
>>
> A few noobish questions/requests:
>   - Does cmake uses the C or C++ compiler to build the .c files ?
> If the former please drop the casts around wcore_calloc() and use
> designated initializer for the vtable.

That's right, I can change in to this style now. I previously had used 
cmake language properties for nacl files and set it C++ and that is why 
I've made these changes. But now only the single cpp file gets c++ 
compiled. Good catch!

>   - Please avoid adding include <std{bool,io}.h> in the "top" headers
> (nacl_platform.h nacl_window.h), but where they are needed.
>
>   - Seems like you can/should update man/waffle_{init,enum}.3.xml with
> this commit.
>
>   - Can you update wcore_enum_to_string() in src/waffle/core/wcore_util.c

Thanks, I'll fix these.

>
> And one bikeshed below, feel free to ignore :)
>
>
>> +extern "C" void
>> +nacl_deinit(nacl_container *nc)
> This is the first time I've see "deinit". Perhaps use the more common
> nacl_fini instead ?
>
>
> Cheers,
> Emil
>