[waffle] [PATCH v2 2/4] waffle: add support for building Waffle using NaCl toolchain

[Chad Versace]

On 12/30/2014 11:30 PM, Tapani Pälli wrote:
> On 12/30/2014 12:53 AM, Emil Velikov wrote:
>> On 22/12/14 22:28, Chad Versace wrote:
>>> On 12/21/2014 07:53 AM, Emil Velikov wrote:
>>>> On 17 December 2014 at 10:17, Tapani Pälli <tapani.palli at intel.com> wrote:
>>>>> Patch adds changes required to use NaCl compiler and libraries to
>>>>> build Waffle. Build can be configured to use specific version of
>>>>> the NaCl SDK, toolchain for the build needs to be selected with
>>>>> cmake variable CMAKE_TOOLCHAIN_FILE.
>>>>>
>>>>> Example command line to configure a build:
>>>>>
>>>>> cmake -Dwaffle_has_nacl=ON \
>>>>>        -Dnacl_sdk_path=/home/tpalli/nacl/nacl_sdk \
>>>>>        -Dnacl_version=pepper_39 \
>>>> Tbh I'm not a huge fan of having those piped via the top cmake into
>>>> the toolchain file.
>>>>
>>>> Quick look indicates that nacl_sdk as of Dec 2011 has/is defining NACL_SDL_ROOT.
>>>> Perhaps we can reuse that one and error out if it's missing.
>>>> Considering we can use (have tested only) a single version we could
>>>> just hardcode it into the toolchain file ?
>>>
>>> Emil, I don't understand. What do you mean that nacl_sdk defines NACL_SDK_ROOT?
>>> I see that some GNU Makefiles in the SDK define NACL_SDK_ROOT, but I failed
>>> to find any CMake files in the SDK.
>>>
>> Admittedly I've not fetched/tried the SDK, but I would assume that this
>> commits [1] sets the env var. On the plus side it seems that it works
>> for some (again guesswork) [2]. And the bugreport about the missing way
>> to autodetect the SDK [3].
> 
> This sure looks like a 'development shell' which would set it, I don't know if this is used though because I cannot find it in the SDK or referenced by the 'Getting started' tutorials, I'm using the SDK from here:
> 
> https://developer.chrome.com/native-client/sdk/download
> 
> Maybe they had it but it was removed or optional to have (?) Current instructions suggest that building is done in the users environment (regular shell).

I unlocked the mystery of the script [https://code.google.com/p/nativeclient-sdk/source/detail?r=1385]
that Emil found. It was removed in 2013 by this commit.

commit e8e285bb762580dff4e3c880a8ece9e1fa176d29
Author: binji at chromium.org <binji at chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>
Date:   Wed Mar 27 19:02:11 2013 +0000

    [NaCl SDK] A bunch of spelling fixes.
    
    Also, removed set_nacl_env.py from sdk_tools directory. It is unused.
    
    BUG=none
    R=sbc at chromium.org
    NOTRY=true
    
    
    Review URL: https://chromiumcodereview.appspot.com/13106002
    
    git-svn-id: svn://svn.chromium.org/chrome/trunk/src@190994 0039d316-1c4b-4281-b951-d872f2087c98


Emil, the CMake toolchain file you found relies on an ancient version of the NaCl SDK. I doubt
that toolchain file still works.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 884 bytes
Desc: OpenPGP digital signature
URL: <http://lists.freedesktop.org/archives/waffle/attachments/20141231/80f179c7/attachment.sig>