[waffle] [PATCH 15/33] c99: use strerror_s over strerror_r under Windows

Emil Velikov emil.l.velikov at gmail.com
Thu Jul 17 06:19:19 PDT 2014


On 17/07/14 05:36, Chad Versace wrote:
> On 07/07/2014 10:28 AM, Emil Velikov wrote:
> 
>> +/*
>> + * strerror_r (strictly speaking not C99)
>                   ^^^^^^^^^^^^^^^^^^^^^^^^^^
> You documented what's wrong with defining strerror_r in a C99
> compatibility header. But it would be nice to also document what's
> *right*. Maybe say "Not in C99, but in POSIX.1-2001.".
> 
> Oh... I'm nit-picking.
> /me shuts up and takes the code
> 
No worries. My intent was to avoid explaining the whole history behind
strerror_r - XSI-compliant or not, vs GNU-specific one. I'll add a small note
in there that is slightly more useful.

-Emil
> This patch is
> Reviewed-by: Chad Versace <chad.versace at linux.intel.com>
> 
>> + */
>> +#if defined(_WIN32)
>> +#define strerror_r(errno,buf,len) strerror_s(buf,len,errno)
>> +#endif
> 
> 
> 



More information about the waffle mailing list