[waffle] [PATCH 15/18] cmake: prefix the waffle dll with "lib" similar to other platforms

Jose Fonseca jfonseca at vmware.com
Wed Jul 23 08:18:31 PDT 2014


On 23/07/14 04:31, Emil Velikov wrote:
> XXX: What about the static library (waffle-1.lib) ?
>
> Signed-off-by: Emil Velikov <emil.l.velikov at gmail.com>
> ---
>   src/waffle/CMakeLists.txt | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/src/waffle/CMakeLists.txt b/src/waffle/CMakeLists.txt
> index 9507398..d348cb6 100644
> --- a/src/waffle/CMakeLists.txt
> +++ b/src/waffle/CMakeLists.txt
> @@ -183,6 +183,7 @@ target_link_libraries(${waffle_libname} ${waffle_libdeps})
>
>   set_target_properties(${waffle_libname}
>       PROPERTIES
> +	PREFIX "lib"
>       LIBRARY_OUTPUT_DIRECTORY ${CMAKE_BINARY_DIR}/lib
>       SOVERSION ${waffle_soversion}
>       VERSION ${waffle_soversion}.${waffle_minor_version}.${waffle_patch_version}
>

This may be consistent with other platforms, but it is not very 
consistent with Windows platform normal practice, which IMO is a more 
important consistency.  That said, it would not be the first or last 
time that a project uses the lib prefix on Windows dlls.  So no a big 
deal either way.

Jose


More information about the waffle mailing list