[waffle] [PATCH] android: misc build fixes

Chad Versace chad.versace at linux.intel.com
Thu Jul 31 08:29:14 PDT 2014


On 07/31/2014 06:14 AM, Emil Velikov wrote:
>  - Add $(top)/include to the local_c_includes. Required for c99_compat.h
> header.
>  - Build third_party/threads library, add $(top)/third_party/threads to
> local_c_includes (for threads.h)
>  - pthread_mutex_timedlock is not available in bionic.
>  - Drop unneeded trailing backslash(es).
> 
> Signed-off-by: Emil Velikov <emil.l.velikov at gmail.com>

Did you build-test the patch? I hate to ask, but many times I've seen
developers "fix" Mesa's Android makefiles times and breaking the build.

> ---
> 
> While going through the scons, I've completely missed out that we have 
> another two build setups - Android + Xcode.
> 
> This patch resolves the Android code, and I assume that a similar one is 
> needed for Xcode. Btw why do we have the latter one in git ? AFAICS 
> cmake is perfectly capable of generating a Xcode projects.

I forgot that the Xcode files were still in Waffle. Now deleted in
https://github.com/waffle-gl/waffle/commit/6d7420814725131da771c6beb808913ec951e10b


More information about the waffle mailing list