[waffle] [PATCHv2 04/10] cmake: add autodetection for waffle_has_egl, glx...

Chad Versace chad.versace at intel.com
Tue Jun 10 21:39:07 PDT 2014


On Fri, Jun 06, 2014 at 02:18:37PM +0100, Emil Velikov wrote:
> Silence the pkg_check_modules and check set the default
> options depending on the packages found.
> 
> Error out if the user has selected an option and it's
> requirements are not met.
> 
> v2:
>  - Do not silence pkg_check_modules.
>  - Explicitly list the failing requirements.
> 
> Signed-off-by: Emil Velikov <emil.l.velikov at gmail.com>
> ---
> 
> The patch turned out a bit longer that I would like to,
> although I cannot see any sane way of splitting it up :'(
> 
> At least it nicely prints which dependency is missing, so that
> there should be little-to-no head-bashing from people building
> waffle.

I'm also unhappy how verbose the patch is, but I don't see a way to
shorten it either. Unless we go the way of macro madness.

Thanks for adding messages that will help the unlucky user. It's
committed to master.



More information about the waffle mailing list