[waffle] [PATCH] egl: Fix creation of compatibility contexts

Chad Versace chad at chad-versace.us
Sat Mar 8 19:48:10 PST 2014

On Sat, Mar 8, 2014 at 6:43 PM, Jordan Justen <jljusten at gmail.com> wrote:
> On Sat, Mar 8, 2014 at 9:39 AM, Chad Versace <chad at chad-versace.us> wrote:
> > From: Chad Versace <chad at kiwitree.net>

> > Jordan, this patch is untested because I have access to no Linux computer this
> > weekend.  When you validate the patch, I'll commit it.
> Tested-by: Jordan Justen <jordan.l.justen at intel.com>
> Should this be done only for OpenGL >= 3.2 like in  glx_context.c?

The code in wcore_config_attrs.c emits an error if the use requests a
core or compat profile for GL < 3.2 or for any version of ES. So, it
isn't strictly necessary to duplicate that check in wegl_context.c.
wcore_config_attrs.c ensures that profile is used only for GL >= 3.2.

The code in glx_context.c looks substantially different because GLX
also has a profile bit for ES.

Having said all that, I prefer that code look correct in *local*
context. But, in local context, the code in my patch looks incorrect.
I'll send a v2 patch that resembles the code in glx_context.c.

More information about the waffle mailing list