[waffle] merge of evelikov/remove-libgbm-libgl-libdeps-v2 breaks piglit compilation

[Emil Velikov]

Actually the libEGL situation is way "better". But that will be
unravelled in due cause.

Mark, expect piglit to keep causing you problems, as someone seriously
needs give it some love. Addressing the cmake warnings would a nice start :)

Additionally I do hope that you've made a typo in
PIGLIT_BUILD_DMA_BUG_TESTS as you typed in it here. Otherwise the
dma_buf tests may not have been built :)

-Emil

On 24/11/14 22:35, Emil Velikov wrote:
> Hi there,
> 
> The other day I've noticed that piglit's linkdeps are completely broken,
> and that things were working due to shear luck :\
> 
> I was hoping that the case is only for glut powered builds, but is seems
> that the waffle one is effected as well.
> 
> The problem: libpiglitutil_gl depends on libGL/libEGL but is never
> linked against it. With waffle dropping the link, the bug(s) in piglit
> are uncovered :P
> 
> I'll spin a patch or two for piglit to fix things.
> 
> -Emil
> 
> On 24/11/14 19:41, Mark Janes wrote:
>> Hello,
>>
>> With the latest commit to waffle, I encounter errors linking piglit:
>>
>>   Building C object target_api/gles1/tests/spec/oes_compressed_etc1_rgb8_texture/CMakeFiles/oes_compressed_etc1_rgb8_texture-basic.dir/oes_compressed_etc1_rgb8_texture-basic.c.o
>>   ../../../../../lib/libpiglitutil_gles1.so.0: undefined reference to `glXGetProcAddressARB'
>>
>> I'll put the compilation commands below, to show the options I've
>> enabled.  Dylan verified that a standard rebuild in gentoo produces the
>> same error after emerge.
>>
>> My waffle build steps:
>> $ PKG_CONFIG_PATH=/tmp/build_root/m64/lib/x86_64-linux-gnu/pkgconfig:/tmp/build_root/m64/lib/pkgconfig:/usr/lib/x86_64-linux-gnu/pkgconfig:/usr/lib/pkgconfig CC=ccache gcc CXXFLAGS=-m64 CFLAGS=-m64 CXX=ccache g++ cmake /var/lib/jenkins/jobs/Leeroy/workspace/repos/waffle -DCMAKE_INSTALL_PREFIX:PATH=/tmp/build_root/m64 -Dwaffle_has_x11_egl=1 -Dwaffle_has_glx=1 -Dwaffle_has_gbm=1
>>
>> $ cmake --build /var/lib/jenkins/jobs/Leeroy/workspace/repos/waffle/build_m64
>>
>> $ make install
>>
>>
>> My piglit build steps:
>>
>> $ PKG_CONFIG_PATH=/tmp/build_root/m64/lib/x86_64-linux-gnu/pkgconfig:/tmp/build_root/m64/lib/pkgconfig:/usr/lib/x86_64-linux-gnu/pkgconfig:/usr/lib/pkgconfig CC=ccache gcc CXXFLAGS=-m64 CFLAGS=-m64 CXX=ccache g++ cmake /var/lib/jenkins/jobs/Leeroy/workspace/repos/piglit-build -DCMAKE_INSTALL_PREFIX:PATH=/tmp/build_root/m64 -DPIGLIT_BUILD_DMA_BUG_TESTS=1 -DPIGLIT_BUILD_GLES1_TESTS=1 -DPIGLIT_BUILD_GLES2_TESTS=1 -DPIGLIT_BUILD_GLES3_TESTS=1 -DPIGLIT_BUILD_GL_TESTS=1 -DPIGLIT_BUILD_GLX_TESTS=1 -DPIGLIT_BUILD_CL_TESTS=0
>>
>> $ cmake --build /var/lib/jenkins/jobs/Leeroy/workspace/repos/piglit-build/build_m64
>>
>>
>> Let me know if you have any trouble reproducing the link error.
>>
>> -Mark
>>
>