[waffle] [PATCH 00/10] nacl dl rework and header cleanups et all

[Chad Versace]

On Tue 24 Mar 2015, Emil Velikov wrote:
>Hi all,
>
>Was pondering on the trivial nacl_dl* nitpick I was talking about
>earlier and I've noticed something more interesting along the way.
>Namely: in some places in waffle we include headers explicitly wrapped
>for C linkage (extern "C" { #include "foo.h" }).
>
>As mentioned by Jose over at mesa-dev and Oracle's acticle [1] one
>should avoid doing so as the system headers might have C++ symbols.
>
>So with this series I've added added extra guards where needed, reworked
>the header inclusion, and nacl_cl similar to other parts in waffle and
>added a few missing pragma once guards.
>
>Patch 6 is slightly on the bikeshed side, so I won't object it people
>want to take it out the back and shoot it :-P

Emil, these cleanups look good to me. And I agree that bike-sheddy patch
6 does make the code a bit more readable. All patches are

Reviewed-by: Chad Versace <chad.versace at intel.com>

Please add mine and Tapani's r-b's to your patches and send a pull
request. (I tried applying and pushing the patches myself, but
encountered some git-am conflicts I didn't understand).