[waffle] [PATCH v2] waffle: add full screen window request

Emil Velikov emil.l.velikov at gmail.com
Thu Apr 23 02:27:24 PDT 2015


On 16 April 2015 at 16:32, Frank Henigman <fjhenigman at google.com> wrote:
> You can now put WAFFLE_WINDOW_FULLSCREEN in the attribute list passed
> to waffle_window_create2() and get a full screen window.
> Only glx and x11_egl implemented so far.
>
> Signed-off-by: Frank Henigman <fjhenigman at google.com>
> ---
> v2
> - value, not mere presence, of WAFFLE_WINDOW_FULLSCREEN attribute
>   determines full screen request
> - process all size attributes in waffle_window_create2() so the platforms
>   don't have to
> - return an error from all platforms that don't support full screen
>   - NOTE: I HAVE NOT EVEN COMPILED MOST OF THESE
> - update wcore_enum_to_string()
> - update documentation
>
FWIW I really like how you made -1 x -1 as an internal representation
of fullscreen. That plus need_update saves a fair bit of code movement
in the patch.

Nicely done !

-Emil


More information about the waffle mailing list