[waffle] [RFC 2/3] wflinfo.c: split version, renderer, and vendor checks

Chad Versace chad.versace at intel.com
Wed Dec 30 12:10:33 PST 2015


On 12/29/2015 02:37 PM, Dylan Baker wrote:
> Okay, I can fix that too.
> 
> On Sun, Dec 27, 2015 at 7:43 AM, Frank Henigman <fjhenigman at google.com <mailto:fjhenigman at google.com>> wrote:
> 
>     On Wed, Dec 16, 2015 at 8:37 PM,  <baker.dylan.c at gmail.com <mailto:baker.dylan.c at gmail.com>> wrote:
>     > From: Dylan Baker <baker.dylan.c at gmail.com <mailto:baker.dylan.c at gmail.com>>
>     >
>     > Pull these out into helper functions, this change will be used in a
>     > following patch to add a json printer.
>     >
>     > Signed-off-by: Dylan Baker <dylanx.c.baker at intel.com <mailto:dylanx.c.baker at intel.com>>
>     > ---
>     >  src/utils/wflinfo.c | 50 ++++++++++++++++++++++++++++++++++++--------------
>     >  1 file changed, 36 insertions(+), 14 deletions(-)

>     > +    const char * vendor =  get_vendor();
>     > +    const char * renderer = get_renderer();
>     > +    const char * version_str = get_version();
> 
>     nit: usually no space after *

Yes. The convention in Waffle is ``const char *vendor``. Other than that,
the patch looks good.



More information about the waffle mailing list