[waffle] [PATCH] cmake: update minimum required MSVC version to 2013 Update 4

Emil Velikov emil.l.velikov at gmail.com
Thu Feb 5 09:18:04 PST 2015


On 5 February 2015 at 16:51, Jose Fonseca <jfonseca at vmware.com> wrote:
> Emil,
>
> After my piglit change, I had to fix it as
>
>
> http://cgit.freedesktop.org/piglit/commit/?id=1dca1680c1b29cf1eb242cf8c51e157ca88c929d
>
> otherwise CMake would complain about invalid syntax outside MSVC.
>
> With that,
>
>   Reviewed-by: Jose Fonseca <jfonseca at vmware.com>
>
Silly me - I've completely missed out that the patch has the ${}
around MSVC. Dropped now and confirmed working.

Thanks
Emil


More information about the waffle mailing list