[waffle] [wflinfo] [RFC] platform-specific info from wflinfo

Dylan Baker baker.dylan.c at gmail.com
Tue Feb 10 10:31:23 PST 2015


I like this idea, it would be convenient for piglit to be able to assume
waffle info can provide all of the information we currently call out to
multiple binaries for.

On Sun, Feb 08, 2015 at 07:50:15PM -0500, Frank Henigman wrote:
> I'd like to extend wflinfo so it can print platform-specific
> information and eventually be able to replace glxinfo, eglinfo and the
> like (I only know what's on linux).  There would be a new flag to
> request the platform-specific output in addition to the existing
> output.  For example on glx you'd see glx extensions, on egl you'd see
> egl extensions.
> I've started two different implementations and I'd like to know which
> is preferred before I go any farther.  Or if there's a better idea
> than either of my approaches.  I've dubbed the two approaches "native"
> and "core."
> 
> native
> - all the work is done in wflinfo, no changes to waffle api
> - use waffle_display_get_native() to access platform-specific stuff
> - pro: changes limited to wflinfo, doesn't clutter up the rest of waffle
> - con: some duplicate code to open libraries and lookup symbols
> - https://github.com/fjhenigman/waffle/tree/ps_native
> 
> core
> - add waffle_display_print_info() to waffle api
> - add print_info() method to each platform
> - pro: less code, no duplication
> - con (perhaps): some wflinfo functionality is now in core waffle
> - https://github.com/fjhenigman/waffle/tree/ps_core
> 
> I'm leaning toward "core" because there is less code.  We get to
> leverage the platform libraries and functions already stored in waffle
> platform structs.  But if the consensus is it's cleaner to keep this
> stuff in wflinfo I'm ok with that too.
> _______________________________________________
> waffle mailing list
> waffle at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/waffle
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: Digital signature
URL: <http://lists.freedesktop.org/archives/waffle/attachments/20150210/47ac49ad/attachment.sig>


More information about the waffle mailing list