[waffle] [PATCH v3] nacl: add implementation for waffle_dl_sym
Emil Velikov
emil.l.velikov at gmail.com
Wed Feb 18 13:58:39 PST 2015
On 18/02/15 05:58, Tapani wrote:
> On 02/18/2015 01:37 AM, Emil Velikov wrote:
>> On 16/02/15 06:49, Tapani Pälli wrote:
>>> v2: use wcore_calloc, code cleanup (Emil Velikov)
>>> open dll only once in can_open (Chad Versace)
>>> v3: print both dlopen and dlsym error, if dll could
>>> not be opened on dl_sym (Emil Velikov)
>>>
>> Rather than wasting your time with this I will follow up with a patch in
>> due time.
>>
>> After all it's a trivial thing, on the grand scheme of things.
>>
>> How does that sound ?
>
> So I did not get it right (?) A follow-up patch sounds fine with me.
>
waffle_dl_can_open() returns a bool and as such it does not set a waffle
error. At least the other platforms don't (modulo a bug or two).
On the other hand waffle_dl_sym returns a pointer, and sets an error on
failure.
So things need to be resuffled a bit, but as said earlier this is really
nitpicking so don't worry about it :-)
-Emil
More information about the waffle
mailing list