[waffle] [PATCH 15/17] waffle: Add public func waffle_window_create2() (v2)

Emil Velikov emil.l.velikov at gmail.com
Thu Jan 15 04:35:57 PST 2015


Hi Chad,

On 4 January 2015 at 22:03, Chad Versace <chad.versace at intel.com> wrote:
> Today, waffle_window() has only two parameters: width and height.
>
> Frank Henigman wants to extend Waffle's GBM backend with the ability to
> post window contents to the display. Multiple methods exist for posting
> content to the screen with the drm API, and that method should be
> configurable per waffle_window. Therefore, we need to be able to pass
> additional attributes to waffle_window_create().
>
> It would also be nice to specify at time of creation that the
> waffle_window should be full screen. Again, we need to pass additional
> attributes to waffle_window_create().
>
> The new function waffle_window_create2() is conceptually equivalent to
> the original waffle_window_create() with the addition of an attrib_list
> parameter.  The only supported attributes are currently
> WAFFLE_WINDOW_WIDTH and WAFFLE_WINDOW_HEIGHT.
>
> See the manpage changes for more details.
>
Almost forgot about the way we handle the exported/public symbols in MSVC.
Can you squash the following into this patch please.

diff --git a/src/waffle/waffle.def.in b/src/waffle/waffle.def.in
index db8464f..ca3078a 100644
--- a/src/waffle/waffle.def.in
+++ b/src/waffle/waffle.def.in
@@ -20,6 +20,7 @@ EXPORTS
     waffle_context_destroy
     waffle_context_get_native
     waffle_window_create
+    waffle_window_create2
     waffle_window_destroy
     waffle_window_show
     waffle_window_swap_buffers


Thanks
Emil


More information about the waffle mailing list