[waffle] [PATCH 05/17] core: Define wcore_attrib_list funcs with type-generic template
chad.versace at intel.com
Tue Jan 20 10:53:47 PST 2015
On 01/15/2015 04:40 AM, Emil Velikov wrote:
> On 4 January 2015 at 22:02, Chad Versace <chad.versace at intel.com> wrote:
>> The current wcore_attrib_list functions work on int32_t attribute lists.
>> A future commit will add variants that work on intptr_t attribute lists.
>> To prevent code duplication, this patch moves the definition of all
>> wcore_attrib_list32 functions into a type-generic macro,
>> WCORE_ATTRIB_LIST_COMMON_FUNCS, which will also be used to define the
>> upcoming intptr_t functions.
> Despite that the approach looks great imho, I'm not 100% sure that
> MSVC will like the macros.
> Either way that will be addressed when it's confirmed that it causes an issue.
Do you still have an MSVC build environment available to build-test the series
before I merge it to master? I don't want to break the MSVC build on master, if
it's not not too much trouble to prevent.
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 884 bytes
Desc: OpenPGP digital signature
More information about the waffle