[waffle] [PATCH] wflinfo: Fix MSVC compilation error.

Jose Fonseca jfonseca at vmware.com
Fri Jan 30 12:02:32 PST 2015

On 30/01/15 16:25, Emil Velikov wrote:
> On 30 January 2015 at 11:07, Jose Fonseca <jfonseca at vmware.com> wrote:
>> Workaround what seems to be a bug in MSVC parser for C99.
>> https://urldefense.proofpoint.com/v2/url?u=http-3A__lists.freedesktop.org_archives_waffle_2015-2DJanuary_000975.html&d=AwIBaQ&c=Sqcl0Ez6M0X8aeM67LKIiDJAXVeAw-YihVMNtXt-uEs&r=zfmBZnnVGHeYde45pMKNnVyzeaZbdIqVLprmZCM2zzE&m=EOTSIhn-7yCkuKuQ-JCDhS7EtrWFaozBDxo228XaWso&s=0Bi5_OB7Grl7-w1RO8R0l0YtCyi9IkRu-lB9Jtt7Ono&e=
> Should have spotted this a Frank sent out the patch. Sorry about this Jose.
> Reviewed-by: Emil Velikov <emil.l.velikov at gmail.com>
> Wondering if we should (as a follow up commit) move the variable
> declarations prior to the code to avoid such fun in the future ?

It's hard to say.

It looks like MSVC allows declarations in the middle of blocks, but the 
parser gets into a wierd state some times.

I think the surer way long term would be to report the MSVC bug to 
Microsoft.  There have been positive experiences in the past [1] [2]


[1] https://bugs.freedesktop.org/show_bug.cgi?id=58718#c17

More information about the waffle mailing list