[waffle] [PATCH 00/10] nacl dl rework and header cleanups et all
Emil Velikov
emil.l.velikov at gmail.com
Tue Mar 24 08:56:16 PDT 2015
Hi all,
Was pondering on the trivial nacl_dl* nitpick I was talking about
earlier and I've noticed something more interesting along the way.
Namely: in some places in waffle we include headers explicitly wrapped
for C linkage (extern "C" { #include "foo.h" }).
As mentioned by Jose over at mesa-dev and Oracle's acticle [1] one
should avoid doing so as the system headers might have C++ symbols.
So with this series I've added added extra guards where needed, reworked
the header inclusion, and nacl_cl similar to other parts in waffle and
added a few missing pragma once guards.
Patch 6 is slightly on the bikeshed side, so I won't object it people
want to take it out the back and shoot it :-P
Cheers,
Emil
[1] http://www.oracle.com/technetwork/articles/servers-storage-dev/mixingcandcpluspluscode-305840.html#c_from_cpp
More information about the waffle
mailing list