[waffle] [PATCH v2 04/10] nacl: rework nacl_dl functions

[Emil Velikov]

On 26 March 2015 at 05:56, Tapani Pälli <tapani.palli at intel.com> wrote:
> On 03/25/2015 04:22 PM, Emil Velikov wrote:
>>
>> This is a direct copy from cgl with the following tweaks
>>   - s/cgl/nacl/
>>   - s/cgl_dl_gl_path/NACL_GLES2_LIBRARY/
>>   - Add move the nacl_prefix function from nacl_platform.c
>>
>> Doing this allows us to have more consistent codebase and additional
>> error messages for the user. As a bonus it squashes a bug where
>> waffle_dl_can_open() was setting an error when it shouldn't have.
>>
>> v2:
>>   - s/gl_dl/dl_gl/ nacl_platform.* : the latter is used throughout waffle
>>   - s/cgl_dl_gl_path/NACL_GLES2_LIBRARY/ - missed a couple of references
>>   - add missing includes - stdio.h, string.h, nacl_container.h
>>
>> Cc: Tapani Pälli <tapani.palli at intel.com>
>> Signed-off-by: Emil Velikov <emil.l.velikov at gmail.com>
>> ---
>>
>> Tapani, this update addresses only the compilation goofups. This way
>> people can give it a test if interested. v3 will be comming after the
>> input of my follow up questions.
>>
>> How did you structure the files for your test [1] ? All the requirements
>> (SOs, etc.) are next to the nexe,nmf,html and Chromium is running with
>> --enable-nacl, yet nothing pops up. Your test runs like a charm though :-)
>
>
> I have all the dependencies in same directory as the test, this is because
> we use '--no-arch-prefix' when creating nmf file (see CMakeLists.txt for the
> reason ..) I should probably file a bug/change request for create_nmf tool
> because it would be nice to have each arch in their own path like it is
> designed even when using '-x' flag.
>
> For nmf file issues, easy way to check what is missing is to turn on
> developer tools from chrome's 'More tools' menu and from there check the
> Network tab. You should also see some errors on console there, maybe some of
> the dependencies is not found or has wrong file permissions.
>
Found out what's the problem - "For security reasons, Native Client
applications must come from a server". It was slightly painful going
through the developer web pages [1] via google' cache but we got there
:-) Is it just me or the whole Native Client section returns:

Not Found
No API or article found

for a few days now ?


-Emil

[1] https://developer.chrome.com/native-client/devguide/devcycle/running