[waffle] [PATCH 3/4] glx: remove dl_can_open restriction for supports_context_api()

Emil Velikov emil.l.velikov at gmail.com
Tue Sep 1 05:35:51 PDT 2015


This seems like unnecessary book-keeping which makes the topic
"supported by the display" vs "there is a library that one can manage"
more convoluted than needed.

One can safely assume that if the GLX implementation exposes the
extension(s) then it supports the API. Whether it will succeed in
creating such a context is another topic :)

Signed-off-by: Emil Velikov <emil.l.velikov at gmail.com>
---
 src/waffle/glx/glx_display.c | 12 +++---------
 1 file changed, 3 insertions(+), 9 deletions(-)

diff --git a/src/waffle/glx/glx_display.c b/src/waffle/glx/glx_display.c
index 567d442..d0490e6 100644
--- a/src/waffle/glx/glx_display.c
+++ b/src/waffle/glx/glx_display.c
@@ -123,17 +123,11 @@ glx_display_supports_context_api(struct wcore_display *wc_self,
         case WAFFLE_CONTEXT_OPENGL:
             return true;
         case WAFFLE_CONTEXT_OPENGL_ES1:
-            return self->EXT_create_context_es_profile
-                   && linux_platform_dl_can_open(plat->linux,
-                                                 WAFFLE_DL_OPENGL_ES1);
+            return self->EXT_create_context_es_profile;
         case WAFFLE_CONTEXT_OPENGL_ES2:
-            return self->EXT_create_context_es2_profile
-                   && linux_platform_dl_can_open(plat->linux,
-                                                 WAFFLE_DL_OPENGL_ES2);
+            return self->EXT_create_context_es2_profile;
         case WAFFLE_CONTEXT_OPENGL_ES3:
-            return self->EXT_create_context_es_profile
-                   && linux_platform_dl_can_open(plat->linux,
-                                                 WAFFLE_DL_OPENGL_ES3);
+            return self->EXT_create_context_es_profile;
         default:
             wcore_error_internal("waffle_context_api has bad value %#x",
                                  context_api);
-- 
2.5.0



More information about the waffle mailing list