[waffle] [PATCH 6/6] nacl: Add an error when trying to use a robust access context.

Tapani Pälli tapani.palli at intel.com
Thu Apr 7 04:59:09 UTC 2016


This looks correct to me;

Reviewed-by: Tapani Pälli <tapani.palli at intel.com>

Note that following patch is required to build waffle nacl support on 
any recent nacl sdk versions:

https://lists.freedesktop.org/archives/waffle/2015-October/001266.html


On 04/06/2016 06:59 PM, Bas Nieuwenhuizen wrote:
> Signed-off-by: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>
> ---
>   src/waffle/nacl/nacl_config.c | 6 ++++++
>   1 file changed, 6 insertions(+)
>
> diff --git a/src/waffle/nacl/nacl_config.c b/src/waffle/nacl/nacl_config.c
> index 9017775..668657b 100644
> --- a/src/waffle/nacl/nacl_config.c
> +++ b/src/waffle/nacl/nacl_config.c
> @@ -63,6 +63,12 @@ nacl_config_choose(struct wcore_platform *wc_plat,
>           goto error;
>       }
>
> +    if (attrs->context_robust) {
> +        wcore_errorf(WAFFLE_ERROR_UNSUPPORTED_ON_PLATFORM,
> +                     "NaCl does not support robust contexts.");
> +        goto error;
> +    }
> +
>       unsigned attr = 0;
>
>       // Max amount of attribs is hardcoded in nacl_config.h (64)
>


More information about the waffle mailing list