[waffle] [PATCH v3] wflinfo: Add a --format flag that prints json or the classic output

Chad Versace chad.versace at intel.com
Thu Apr 7 18:22:40 UTC 2016


On 01/14/2016 04:42 PM, baker.dylan.c at gmail.com wrote:
> From: Dylan Baker <baker.dylan.c at gmail.com>
> 
> Adds a JSON formatted output.
> 
> This format doesn't honor the --verbose flag, it always provides all
> relevant information.
> 
> The option parsing code is a slightly adapted version of code Frank
> Henigman wrote.
> 
> Signed-off-by: Dylan Baker <dylanx.c.baker at intel.com>
> ---
> v2: - Add -j short options (Frank)
>     - Make context flags always an array (Chad)
>     - Remove explicit returns from void functions (Chad)
>     - Fix spaces around "*" in variable definitions
>     - Nest waffle specific information in a waffle hash and OpenGL
>       specific information in an OpenGL hash
>     - use ARRAY_SIZE macro
>     - rebase on previous changes
> v3: - Fix various formatting issues
>     - conform to Chad's requested JSON format
>     - add some comments for ambiguous JSON commas
>     - remove context flags, which are not part of Chad's JSON format
>     - remove honoring verbose flag
>     - use a --format flag

Hi Dylan,

I pushed your patch to master.

I took the liberty of fixing two potential crashes in your
patch, both related to strtok(). See the commit message for details.

The new JSON format is a significant new feature that warrants a new
Waffle release in the near future. I'll ping you (and the list) when
I'm ready to cut the new release. First, though, I want to merge some
more outstanding patches on the mailing list.



More information about the waffle mailing list