[waffle] [PATCH 1/6] wcore: Add support for robust access contexts.

[Bas Nieuwenhuizen]

Could this be also committed with those changes or do you want me to
make a v2 that removes the version check? I don't have commit access.

Thanks,
Bas Nieuwenhuizen



On Mon, Apr 11, 2016 at 10:12 PM, Emil Velikov <emil.l.velikov at gmail.com> wrote:
> On 11 April 2016 at 21:11, Emil Velikov <emil.l.velikov at gmail.com> wrote:
>> On 6 April 2016 at 16:59, Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl> wrote:
>>> Signed-off-by: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>
>>> ---
>>>  include/waffle/waffle.h              |  4 ++++
>>>  man/waffle_config.3.xml              | 24 ++++++++++++++++++++++++
>>>  src/waffle/core/wcore_config_attrs.c |  3 +++
>>>  src/waffle/core/wcore_config_attrs.h |  1 +
>>>  src/waffle/core/wcore_util.c         |  1 +
>>>  5 files changed, 33 insertions(+)
>>>
>>> diff --git a/include/waffle/waffle.h b/include/waffle/waffle.h
>>> index df0218e..b207f37 100644
>>> --- a/include/waffle/waffle.h
>>> +++ b/include/waffle/waffle.h
>>> @@ -142,6 +142,10 @@ enum waffle_enum {
>>>      WAFFLE_CONTEXT_DEBUG                                        = 0x0216,
>>>  #endif
>>>
>>> +#if WAFFLE_API_VERSION >= 0x106
>>> +    WAFFLE_CONTEXT_ROBUST_ACCESS                                = 0x0217,
>>> +#endif
>>> +
>> Silly me should have mentioned that we decided against using feature
>> (version) checks for the enums. Unless anyone feels otherwise I'd just
>> say go with the patch [as-is] and nuke any such checks in one go. Both
>> in the source and man pages.
>>
> To hasty to press "Send"
>
> The series is:
> Reviewed-by: Emil Velikov <emil.velikov at collabora.com>
>
> Thanks Bas !
>
> -Emil