[waffle] [PATCH] egl: correctly set the attrib/bits for robust contexts

[Emil Velikov]

On 16 April 2016 at 00:34, Emil Velikov <emil.l.velikov at gmail.com> wrote:
> The EXT_create_context_robustness extension covers only GLES contexts,
> while the latter EGL_KHR_create_context works for both GL and GLES ones.
>
Actually the second extension seems a bit inconsistent. The following
section clearly lists GLES

    OpenGL and OpenGL ES Context Flags
    ----------------------------------

    If the EGL_CONTEXT_OPENGL_ROBUST_ACCESS_BIT_KHR bit is set in
    EGL_CONTEXT_FLAGS_KHR, then a context supporting <robust buffer
    access> will be created.

Then it continues with

    Robust buffer access is defined in the
    GL_ARB_robustness extension specification, and the resulting context
    must also support either the GL_ARB_robustness extension, or a
    version of OpenGL incorporating equivalent functionality. This bit
    is supported for OpenGL contexts.


Then issues 7 and 10 go to confirm that GLES and robustness is not a
thing in this extension, yet no-one bothered moving the hunk to the
OpenGL only section :'-(

This spec is quite and interesting read - forward compat seems to be
in the exact same boat. While debug is funnier - added with the GL +
GLES section initially, discarded as not supported in issue 7, then
brought back with issue 9.

So overall I should bring the KHR_create_context bits back into OpenGL
denominator.

-Emil