[waffle] [PATCH] egl: resolve build issue with pre EGL 1.5 headers

Tapani Pälli tapani.palli at intel.com
Fri Aug 19 07:24:12 UTC 2016



On 08/18/2016 01:27 PM, Emil Velikov wrote:
> On 20 July 2016 at 17:27, Emil Velikov <emil.l.velikov at gmail.com> wrote:
>> In some cases (like building on Android) the headers might not have the
>> 1.5 definitions, leading to a build failures like the one in github
>> issue #41.
>>
>> Since the ABI is baked in stone, add a local define to resolve that.
>>
>> Cc: Chad Versace <chad.versace at intel.com>
>> Fixes: f8a485e7cc7 ("egl: Improve support for robust GLES contexts on
>> EGL 1.5")
>> Issue: https://github.com/waffle-gl/waffle/issues/41
>> Signed-off-by: Emil Velikov <emil.l.velikov at gmail.com>
>> ---
>>  src/waffle/egl/wegl_context.c | 5 +++++
>>  1 file changed, 5 insertions(+)
>>
>> diff --git a/src/waffle/egl/wegl_context.c b/src/waffle/egl/wegl_context.c
>> index 0e59231..97931fc 100644
>> --- a/src/waffle/egl/wegl_context.c
>> +++ b/src/waffle/egl/wegl_context.c
>> @@ -34,6 +34,11 @@
>>  #include "wegl_platform.h"
>>  #include "wegl_util.h"
>>
>> +// Pre EGL 1.5 headers lack the definition.
>> +#ifndef EGL_CONTEXT_OPENGL_ROBUST_ACCESS
>> +#define EGL_CONTEXT_OPENGL_ROBUST_ACCESS  0x31B2
>> +#endif
>> +
> Humble poke ?

LGTM (checked that the values is correct):

Reviewed-by: Tapani Pälli <tapani.palli at intel.com>


> -Emil
> _______________________________________________
> waffle mailing list
> waffle at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/waffle
>


More information about the waffle mailing list