[waffle] [PATCH v2 3/4] wflinfo.c: split version, renderer, and vendor checks

Chad Versace chad.versace at intel.com
Fri Jan 8 14:41:36 PST 2016


On 01/05/2016 11:46 AM, baker.dylan.c at gmail.com wrote:
> From: Dylan Baker <baker.dylan.c at gmail.com>
> 
> Pull these out into helper functions, this change will be used in a
> following patch to add a JSON printer.
> 
> Signed-off-by: Dylan Baker <dylanx.c.baker at intel.com>
> 
> v2: - change "const char * name" to "const char *name" (Frank)
> ---
>  src/utils/wflinfo.c | 50 ++++++++++++++++++++++++++++++++++++--------------
>  1 file changed, 36 insertions(+), 14 deletions(-)

Patches 1-3 are
Reviewed-by: Chad Versace <chad.versace at intel.com>

For patch 4, I'm waiting for you to address the `i != flag_count`
issue, and any resultant newline fixups.

I just began reading Frank's series, btw. I haven't decided yet
how your two series should interact.


More information about the waffle mailing list