[waffle] [PATCH 06/12] wflinfo: add option for JSON output
Chad Versace
chad.versace at intel.com
Tue Jun 14 22:50:37 UTC 2016
On Thu 21 Apr 2016, Frank Henigman wrote:
> On Fri, Apr 8, 2016 at 8:14 PM, Chad Versace <chad.versace at intel.com> wrote:
> > On 01/06/2016 11:56 AM, Frank Henigman wrote:
> I really hope we can keep this simple.
>
> I mentioned in the cover letter to this series that the next step is
> to gut wflinfo and translate json to the old format. We can insert
> that after this patch if you like. Option 1 is the nicest by far, if
> the translator is written in python. It's just a few lines of code to
> read the json, plus a table that lists the correspondence between old
> format lines and json keys. So we have some really simple C code to
> call the waffle api and get the json, and a really simple python
> script to translate to old format. I've got this much roughed out.
> For maximum backward compatibility these two bits would be tied
> together by a script that accepts all the options currently accepted
> by wflinfo, i.e. we replace wflinfo with a script. Which for
> portability is also written in python. Yes this introduces a
> dependency on python to run wflinfo, but I doubt that's much of a
> problem.
I'm open to exploring that path. I just took a serious look at
wflinfo.c, and it's needless complex for the little job that it does. If
you could port it to Python, greatly reducing and simplifying the code,
I'd like to see that.
I've never used Python's C interface, so I look forward to learning
about it from your patches.
More information about the waffle
mailing list