[waffle] [PATCH 5/7] surfaceless_egl: Implement new platform

[Emil Velikov]

On 18 October 2016 at 18:33, Chad Versace <chadversary at chromium.org> wrote:
> Now waffle_init() supports WAFFLE_PLATFORM_SURFACELESS_EGL.
>
> Cc: Gurchetan Singh <gurchetansingh at chromium.org>
> Cc: Haixia Shi <hshi at chromium.org>
> ---
>  include/waffle/waffle.h                  |   1 +
>  man/waffle_init.3.xml                    |   9 ++
>  src/waffle/CMakeLists.txt                |   9 ++
>  src/waffle/api/waffle_init.c             |  12 +++
>  src/waffle/egl/wegl_platform.c           |   6 ++
>  src/waffle/surfaceless_egl/sl_display.c  |  70 +++++++++++++++
>  src/waffle/surfaceless_egl/sl_display.h  |  45 ++++++++++
>  src/waffle/surfaceless_egl/sl_platform.c | 144 +++++++++++++++++++++++++++++++
>  src/waffle/surfaceless_egl/sl_platform.h |  49 +++++++++++
>  src/waffle/surfaceless_egl/sl_window.c   |  92 ++++++++++++++++++++
>  src/waffle/surfaceless_egl/sl_window.h   |  53 ++++++++++++
>  11 files changed, 490 insertions(+)
>  create mode 100644 src/waffle/surfaceless_egl/sl_display.c
>  create mode 100644 src/waffle/surfaceless_egl/sl_display.h
>  create mode 100644 src/waffle/surfaceless_egl/sl_platform.c
>  create mode 100644 src/waffle/surfaceless_egl/sl_platform.h
>  create mode 100644 src/waffle/surfaceless_egl/sl_window.c
>  create mode 100644 src/waffle/surfaceless_egl/sl_window.h
>
Should there be an extra case in src/waffle/core/wcore_util.c's
wcore_enum_to_string() ?

> +// [chadv] I regret the design of the get_native interface, and wish to
> +// deprecate and replace it with the interface that Ian Romanick orignally
> +// recommended: waffle_display_get_egl_display(),
> +// waffle_display_get_gbm_device(), waffle_display_get_xlib_display(), etc.  As
> +// a first step towards that goal, I choose to not support the interface on new
> +// platforms.
Silly question: what's wrong with the current [generic] get_native_{foo,bar} ?

-Emil