[waffle] [PATCH 0/7] Use eglGetPlatformDisplay when possible

Chad Versace chadversary at chromium.org
Wed Oct 19 21:52:46 UTC 2016


On Wed 19 Oct 2016, Emil Velikov wrote:
> On 18 October 2016 at 17:58, Chad Versace <chadversary at chromium.org> wrote:
> > Before EGL_EXT_platform_base and EGL 1.5, when using Mesa the best way
> > to select the EGL platform was to set the EGL_PLATFORM environment
> > variable. Now that a standard way exists, eglGetPlatformDisplay, let's
> > use it when available.
> >
> > After this series, I have a series to add support for
> > EGL_MESA_platform_surfaceless.
> >
> > This branch lives at
> >     https://github.com/chadversary/waffle/commits/review/eglGetPlatformDisplay-v01
> >
> > Chad Versace (7):
> >   egl: Define EGL_PLATFORM_* enums
> >   egl: Update wegl_platform_init signature
> >   egl: Move each platform's setenv("EGL_PLATFORM") into core EGL code
> >   egl: Query client extensions string
> >   egl: Optionally dlsym eglGetPlatformDisplay
> >   egl: Update wegl_display_init signature
> >   egl: Use eglGetPlatformDisplay when possible
> >
> The questions in 5 and 7 are not blockers, by any means. Just please
> split the Android change from 3.
> 
> With that (and the extra Android change itself) are
> Reviewed-by: Emil Velikov <emil.l.velikov at gmail.com>

THANK YOU for reviewing this. You caught some bugs. I'll submit v2 of
individual patches when I return to work on Monday.


More information about the waffle mailing list