[Wayland-bugs] [Bug 52456] [bug] Weston titlebar right-click menu timing issue

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=52456

--- Comment #1 from Brian Lovin <brian.j.lovin at intel.com> 2012-08-14 22:17:42 UTC ---
I was looking at this bug earlier and found that it's because of this if
statement in weston's clients/window.c:

if (state == WL_POINTER_BUTTON_STATE_PRESSED &&
    time - menu->time > 500) {...}

One can change the time - menu->time compare to > 100 and clicking an item is
much snappier, but it seems that this timeout may not be a bug as it is
explicitly written this way. Still a bug, should it be fixed?

I also noticed this comment bellow:
/* Either relase after press-drag-release or
 * click-motion-click. */

Which raises another interesting issue with the menu - it doesn't act like the
comment suggests, which is the way menus work in X11 and Windows so it seems
this is another bug. (The menu commits it's action as soon as the mouse button
is depressed, as the if statement says, instead of when the mouse button is
released as X11/Win do) I'll leave it in this BZ as another item to fix if it
is a bug.

Tested with these sys environments:
glproto master ec1eec4355ee4a6c5134f2178192f10b6d28a87a
mesa master 4e087de51ad0e7ba4a7199d3664e1d096f8dc510
wayland master b57694ca0e9dc7d2845ce9fb0ac9c4b0ebc940ce
pixman master 09cb1ae10b1976970233c934d27c36e0a4203e1c
wayland-test master 14cdb54b5f9320aac9dd3c4dfe490952a40b0250
weston master 4272e639912cac247a04c49ce2a6216100aab65a
drm master 6fa2b29d226306870eebe93afb2106ca7d79569b
efl http://svn.enlightenment.org/svn/e/trunk 74948
cairo master 95b7f4fe3a5deea6766538d843c75626e4bb68cf
libX11 master 8042f88ace33573f9d0dfaa21ed54ac7cef266d5
macros master 0890e4003aacfa7113ab3f4e3ad7c5636f8e922a
libxkbcommon master 4c21275301c453757196d9aa74c00861c0d0d54f
dri2proto master 4eeacce4c4a300b938b7e3fb78a8e443c491780b
kbproto master 391a1f6de6315fc0196d407d800597488315cccb

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.