[Wayland-bugs] [Bug 695998] csd: enable shadows in the outer border

gtk+ (bugzilla.gnome.org) bugzilla at gnome.org
Mon Apr 8 11:38:03 PDT 2013


https://bugzilla.gnome.org/show_bug.cgi?id=695998
  gtk+ | wayland | unspecified

--- Comment #7 from Cosimo Cecchi <cosimo.cecchi at gmail.com> 2013-04-08 18:37:56 UTC ---
Review of attachment 240711:
 --> (https://bugzilla.gnome.org/review?bug=695998&attachment=240711)

This looks good to me as well; only a little stylistic comment below.

::: gtk/gtkcssshadowvalueprivate.h
@@ +35,3 @@
 GtkCssValue *   _gtk_css_shadow_value_parse           (GtkCssParser           
 *parser);

+gboolean        _gtk_css_shadow_value_is_inset        (const GtkCssValue      
 *shadow);

I'd call this _gtk_css_shadow_value_get_inset()

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.


More information about the Wayland-bugs mailing list