[Wayland-bugs] [Bug 67620] New: Code quality issue in weston?

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=67620

          Priority: medium
            Bug ID: 67620
          Assignee: wayland-bugs at lists.freedesktop.org
           Summary: Code quality issue in weston?
          Severity: normal
    Classification: Unclassified
                OS: Linux (All)
          Reporter: jrch2k10 at gmail.com
          Hardware: All
            Status: NEW
           Version: unspecified
         Component: weston
           Product: Wayland

it was pointed out this function in a forum i read

handle_setmaster(struct weston_launch *wl, struct msghdr *msg, ssize_t len)

i saw this 
if (data->fd == -1) {
        error(0, 0, "missing drm fd in socket request");
        goto out; <----
    }

out: <--- this
    do { <--- this
        len = send(wl->sock[0], &ret, sizeof ret, 0);
    } while (len < 0 && errno == EINTR);

it seems to me very ugly but i understand weston is just a reference
implementation too but in case someone wanna use it later would be nice to
improve this, if you guide me a bit[im more of a c++ guy and not familiar with
weston code] i can improve it

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/wayland-bugs/attachments/20130801/93b118e0/attachment.html>