[Wayland-bugs] [Bug 704104] gdk/wayland: cope with the compositor implementing an older protocol than us

[gtk+ (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=704104
  gtk+ | wayland | unspecified

--- Comment #3 from Giovanni Campagna <scampa.giovanni at gmail.com> 2013-07-15 07:47:31 UTC ---
(In reply to comment #2)
> Review of attachment 249018 [details]:
> 
> if we make requests that appeared in a later version I assume we'll have
> fallbacks in place.

Yes, the only request we make is set_buffer_scale (wl_surface v3), which we can
skip by disabling the scaled window support.

> as a side note: at some point, we'll have to fix the coding style of this whole
> backend to fit in with the GDK coding style.
> 
> ::: gdk/wayland/gdkdisplay-wayland.c
> @@ +170,3 @@
>    } else if (strcmp(interface, "wl_output") == 0) {
>      output =
> +      wl_registry_bind(display_wayland->wl_registry, id, &wl_output_interface,
> MIN (version, 2));
> 
> we're not using it, right now, but should we save the output version as well,
> for later use?

We do save the output version and use it (line 173), although we probably
should save the version we're actually requesting, rather than the compositor
version, for forward compatibility.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.