[Wayland-bugs] [Bug 696223] wayland: loading cursors from pixbuf does not work

[gtk+ (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=696223
  gtk+ | wayland | unspecified

Kristian Høgsberg <krh> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #239408|none                        |needs-work
             status|                            |

--- Comment #4 from Kristian Høgsberg <krh at bitplanet.net> 2013-03-21 01:51:21 UTC ---
Review of attachment 239408:
 --> (https://bugzilla.gnome.org/review?bug=696223&attachment=239408)

Tested the patch and it work fine here.  Should be good to commit with the
comments below addressed.

::: gdk/wayland/gdkcursor-wayland.c
@@ +215,3 @@
                     cursor->height,
+                    stride,
+                    WL_SHM_FORMAT_ARGB8888);

Funky indentation here...

We can and should destroy the pool object right after creating the wl_buffer
from it.  Also, wl_buffers from the cursor theme are owned by the theme and
doesn't need to be freed.  In case of a cursor created from a pixbuf (type ==
GDK_CURSOR_IS_PIXMAP), we own the wl_buffer and need to destroy it
(wl_buffer_destroy) in finalize.

Also, I'd fold create_cursor into _gdk_wayland_display_get_cursor_for_pixbuf at
this point.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.