[Wayland-bugs] [Bug 695861] Allow to use custom surfaces for GdkWindows in Wayland

[gtk+ (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=695861
  gtk+ | wayland | 3.7.x

Rob Bradford <rob> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #239363|none                        |needs-work
             status|                            |

--- Comment #4 from Rob Bradford <rob at robster.org.uk> 2013-03-21 18:43:07 UTC ---
Review of attachment 239363:
 --> (https://bugzilla.gnome.org/review?bug=695861&attachment=239363)

Very close - I don't want to bikeshed the function naming too much. But the
principle is great.

::: gdk/wayland/gdkwaylandwindow.h
@@ +48,3 @@
 struct wl_shell_surface *gdk_wayland_window_get_wl_shell_surface (GdkWindow
*window);

+void                     gdk_wayland_window_set_custom_surface   (GdkWindow
*window);

Can we be more direct here? e,g. gdk_wayland_window_set_use_custom_surface. To
me as this name stands i'd expect it to take a parameter of some kind of
"custom surface"

::: gdk/wayland/gdkwindow-wayland.c
@@ +142,3 @@
     } saved_fullscreen, saved_maximized;
+
+  gboolean custom;

I'd rather be more verbose here, e.g. use_custom_surface

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.