[Wayland-bugs] [Bug 75251] glTexSubImage2D call with bad parameters

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=75251

Kristian Høgsberg <krh at bitplanet.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #2 from Kristian Høgsberg <krh at bitplanet.net> ---
Committed on master:

commit 39a443ff9b42ac3a2f7ec3f58230051f2031af24
Author: Neil Roberts <neil at linux.intel.com>
Date:   Fri Apr 4 16:24:54 2014 +0100

    Always use glTexImage2D instead of glTexSubImage2D for first upload

    Previously when uploading SHM data we would initialise the texture
    with glTexImage2D and NULL data when the buffer is attached. Then if
    the GL_EXT_unpack_subimage extension is available we would always use
    glTexSubImage2D to upload the data. The problem with that is that the
    first glTexImage2D was always setting the internal format to
    GL_BGRA_EXT and then if a 16-bit texture is used we would later call
    glTexSubImage2D with a data format of GL_RGBA. Under GLES2 the
    internal format must always match the data format so this is
    technically invalid.

    This patch makes it so that it always calls glTexImage2D when flushing
    the damage for the first time. That way it will use the right internal
    format and we don't need to call glTexImage2D with NULL data.

    https://bugs.freedesktop.org/show_bug.cgi?id=75251

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/wayland-bugs/attachments/20140407/d8085569/attachment.html>