[Wayland-bugs] [Bug 76867] crash going from fullscreen to maximized in weston-stacking

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=76867

Kristian Høgsberg <krh at bitplanet.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #1 from Kristian Høgsberg <krh at bitplanet.net> ---
Fixed in:

commit 641796c31ac5bebf42a630557de734aad01445c9
Author: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira at intel.com>
Date:   Thu Apr 10 16:36:57 2014 +0300

    shell: Keep shsurf->fullscreen_output set after unset_fullscreen()

    When a fullscreen surface gets the maximized state, the function
    reset_surface_type() is called and that causes unset_fullscreen() to be
    called. That function would set the value of shsurf->fullscreen_output
    to NULL. However, since the surface still has the fullscreen state, it
    will be configured as a fullscreen surface again, and an attempt to
    access that field would cause the compositor to crash.

    Fix the crash by keeping the value of fullscreen_output around after
    unset_fullscreen(). This is safe since the value is only used when a
    surface has the fullscreen state and is replaced on a new request to
    make the surface fullscreen.

    https://bugs.freedesktop.org/show_bug.cgi?id=76867

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/wayland-bugs/attachments/20140410/e6fe33a8/attachment.html>