[Wayland-bugs] [Bug 728426] Implement the wl_touch interface

gtk+ (bugzilla.gnome.org) bugzilla at gnome.org
Fri Apr 18 05:36:40 PDT 2014


https://bugzilla.gnome.org/show_bug.cgi?id=728426
  gtk+ | Backend: Wayland | unspecified

Matthias Clasen <mclasen> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #274612|none                        |reviewed
             status|                            |

--- Comment #4 from Matthias Clasen <mclasen at redhat.com> 2014-04-18 12:36:36 UTC ---
Review of attachment 274612:
 --> (https://bugzilla.gnome.org/review?bug=728426&attachment=274612)

::: gdk/wayland/gdkdevice-wayland.c
@@ +1251,3 @@
+  touch = g_new0 (GdkWaylandTouchData, 1);
+  touch->id = id;
+  touch->window = wl_surface_get_user_data(surface);

Missing space here

@@ +1252,3 @@
+  touch->id = id;
+  touch->window = wl_surface_get_user_data(surface);
+  touch->emulates_pointer = (g_hash_table_size (device->touches) == 0);

Maybe this flag would be more descriptive as 'first_touch' or 'initial_touch' ?

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.


More information about the Wayland-bugs mailing list