[Wayland-bugs] [Bug 78706] SIGSEGV in wl_resource_get_client during fullscreen client close animation

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=78706

--- Comment #4 from Boyan Ding <stu_dby at 126.com> ---
(In reply to comment #3)
> Created attachment 105304 [details] [review]
> Stop crash when starting a touch during a fullscreen fade
> 
> This issue is still reproducible today - I think this patch fixes it, but is
> only partially tested because I don't have a touchscreen (I just mashed up
> libinput to pretend my mouse is one).
> 
> If you could test and confirm this works, that would be great.

Looks good, although I don't have a touchscreen to test either.

One little question here: can we use
if (find_resource_for_view(&seat->touch->resource_list, view)) instead of
if (view)
to avoid the problem just as weston_pointer_set_focus do it?

If that can be used, the code will be much cleaner.

I also suggest sending the patch to the mailing list for review.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/wayland-bugs/attachments/20140827/4bddc596/attachment.html>