[Wayland-bugs] [Bug 71750] weston-keyboard disappears during text entry

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Fri Jan 10 00:00:14 PST 2014


https://bugs.freedesktop.org/show_bug.cgi?id=71750

Kristian Høgsberg <krh at bitplanet.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #8 from Kristian Høgsberg <krh at bitplanet.net> ---
Memory corruption fixed by

commit a548b4b85cfdbef103f622c3e3aaf976938535f9
Author: Kristian Høgsberg <krh at bitplanet.net>
Date:   Thu Jan 9 23:39:20 2014 -0800

    keyboard: Fix insert_text() string utility

    strncat() into a newly allocated buffer isn't well-defined.  I don't know
    how this didn't crash all the time, getting blocks from malloc() with
    a NUL in the first byte must be fairly common.

    Closes: https://bugs.freedesktop.org/show_bug.cgi?id=71750

and

commit 700d6ad071614895c3cb305b894b8c1a003db39e
Author: Kristian Høgsberg <krh at bitplanet.net>
Date:   Thu Jan 9 23:45:18 2014 -0800

    keyboard: Don't strcat() into a strdup()ed string

    We need to reallocate the memory to hold the entire concatenated string,
    but strcat() doesn't do that.

    Closes: https://bugs.freedesktop.org/show_bug.cgi?id=71750

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/wayland-bugs/attachments/20140110/f6ca6872/attachment.html>


More information about the Wayland-bugs mailing list