[Wayland-bugs] [Bug 80837] New: xwayland-wm: crash in weston_wm_window_handle_moveresize

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=80837

          Priority: medium
            Bug ID: 80837
          Assignee: wayland-bugs at lists.freedesktop.org
           Summary: xwayland-wm: crash in
                    weston_wm_window_handle_moveresize
          Severity: normal
    Classification: Unclassified
                OS: All
          Reporter: stu_dby at 126.com
          Hardware: Other
            Status: NEW
           Version: unspecified
         Component: weston
           Product: Wayland

The following action will crash weston:
1. launch gnome-terminal under xwayland in weston
2. click on the right side of the menubar (right of "Help" menu)
weston will immediately crash when mouse button is released.

The reason is Xwayland will somehow send a client message type of moveresize
when pointer is released, and weston_wm_window_handle_moveresize will call
weston_wm_pick_seat_for_window, which will always turn NULL if there is no
button pressed. Then weston_wm_pick_seat_for_window will immediately
dereference the NULL pointer.

There are two possible ways if we want to solve the problem on weston side:
1. remove the seat->pointer->button_count > 0 condition in
weston_wm_pick_pointer_for_window to let it return a possible seat
2. check in weston_wm_window_handle_moveresize whether the returned seat is
NULL.

Which is the more appropriate approach?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/wayland-bugs/attachments/20140703/11aed8fc/attachment.html>